Fix a shadow DOM issue where the menu could not be displayed #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `this.getDocument().activeElement` with `this.tribute.current.element` to fix a bug in shadow DOM, where the menu could not be shown. Because `this.getDocument().activeElement` was not the native input element.
|
Fixes part of #76 @mrsweaters this is obviously a quick fix, because the So I would be graceful if you could merge this PR and release a new version 😄 |
|
Merging! I'll go through and update references to activeElement where necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
this.getDocument().activeElementwiththis.tribute.current.elementto fix a bug in shadow DOM, where the menu could not be shown. Becausethis.getDocument().activeElementwas not the native input element.