added more convert functions and extended value tests

zussel · May 10, 2024 · 7acc54f · 7acc54f
1 parent f1469bf
commit 7acc54f
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/include/matador/utils/convert.hpp b/include/matador/utils/convert.hpp
@@ -126,6 +126,12 @@ void convert(utils::blob &dest, const utils::blob &data);
 
 void convert(std::string &dest, const date &source);
 
+template < typename SourceType >
+void convert(date &/*dest*/, SourceType &/*source*/)
+{
+  throw std::logic_error("couldn't convert value into date");
+}
+
 template < typename DestType >
 void convert(DestType &/*dest*/, const time &/*data*/)
 {
@@ -134,6 +140,12 @@ void convert(DestType &/*dest*/, const time &/*data*/)
 
 void convert(std::string &dest, const time &source);
 
+template < typename SourceType >
+void convert(time &/*dest*/, SourceType &/*source*/)
+{
+  throw std::logic_error("couldn't convert value into time");
+}
+
 template < typename DestType >
 void convert(DestType &/*dest*/, const date &/*data*/)
 {

diff --git a/test/catch2/sql/ValueTest.cpp b/test/catch2/sql/ValueTest.cpp
@@ -3,6 +3,8 @@
 #include "matador/sql/types.hpp"
 #include "matador/sql/value.hpp"
 
+#include "matador/utils/date.hpp"
+#include "matador/utils/time.hpp"
 #include "matador/utils/types.hpp"
 
 using namespace matador;
@@ -69,4 +71,20 @@ TEST_CASE("Test value class", "[value]") {
   REQUIRE(v.is_blob());
   REQUIRE(v.data_type() == data_type::type_blob);
   REQUIRE(v.size() == 4);
+
+  const auto today = date{};
+  v = today;
+
+  REQUIRE(v.is_date());
+  REQUIRE(v.data_type() == data_type::type_date);
+  REQUIRE(v.size() == 0);
+  REQUIRE(v.as<date>() == today);
+
+  const auto now = matador::time{};
+  v = now;
+
+  REQUIRE(v.is_time());
+  REQUIRE(v.data_type() == data_type::type_time);
+  REQUIRE(v.size() == 0);
+  REQUIRE(v.as<matador::time>() == now);
 }