Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance observer handling for object store #164

Merged
merged 10 commits into from
May 29, 2024
Merged

Conversation

zussel
Copy link
Owner

@zussel zussel commented May 19, 2024

Observer are still added per type but the methods use now variadic templates.

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 92.24138% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 85.83%. Comparing base (286c50f) to head (7f94521).

Files Patch % Lines
include/matador/object/observer_list_creator.hpp 83.33% 3 Missing ⚠️
src/object/prototype_node.cpp 89.47% 2 Missing ⚠️
include/matador/object/object_store.hpp 95.83% 1 Missing ⚠️
...lude/matador/object/observer_list_copy_creator.hpp 93.75% 1 Missing ⚠️
include/matador/object/prototype_info.hpp 0.00% 1 Missing ⚠️
src/orm/session.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #164      +/-   ##
===========================================
+ Coverage    85.78%   85.83%   +0.05%     
===========================================
  Files          342      342              
  Lines        14468    14456      -12     
===========================================
- Hits         12412    12409       -3     
+ Misses        2056     2047       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zussel zussel merged commit 58fcb59 into develop May 29, 2024
6 checks passed
@zussel zussel deleted the feature/object_store_attach branch May 29, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant