Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): Initial Nice IBT4 BusT4 #2541

Closed
wants to merge 11 commits into from
Closed

feat(config): Initial Nice IBT4 BusT4 #2541

wants to merge 11 commits into from

Conversation

cdnninja
Copy link
Contributor

@cdnninja cdnninja commented May 5, 2021

Started on slot one.

@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label May 5, 2021
AlCalzone
AlCalzone requested changes May 6, 2021
View reviewed changes
packages/config/config/devices/0x0441/ibt4zwave.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0441/ibt4zwave.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0441/ibt4zwave.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0441/ibt4zwave.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0441/ibt4zwave.json Outdated Show resolved Hide resolved
@cdnninja cdnninja changed the title Initial Slot One Work feat(config): Initial Nice IBT4 BusT4 May 8, 2021
AlCalzone
AlCalzone requested changes May 9, 2021
View reviewed changes
Copy link
Member

@AlCalzone AlCalzone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, just some small corrections.
There seems to be a conflict. Please merge in the target branch (or rebase off it).

packages/config/config/devices/0x0441/ibt4zwave.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x0441/ibt4zwave.json Show resolved Hide resolved
@cdnninja
Copy link
Contributor Author

My pull request was from the wrong branch. I think I fixed this with #2576.

@AlCalzone AlCalzone mentioned this pull request May 10, 2021
Merged
@AlCalzone AlCalzone marked this pull request as draft May 10, 2021 10:50
@AlCalzone AlCalzone closed this May 10, 2021
@AlCalzone AlCalzone deleted the branch zwave-js:import-config-1620023644 May 10, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone requested changes

Assignees
No one assigned
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdnninja @AlCalzone