chore: update got to use built-in caching #5090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwave-js-bot approve |
zwave-js-bot
approved these changes
Jan 4, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import os from "os"; | ||
| import path from "path"; | ||
| import "reflect-metadata"; | ||
| import { Driver } from "zwave-js"; | ||
|
|
||
| const wait = _wait; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
AlCalzone
added a commit
that referenced
this pull request
Jan 16, 2023
### Features * Support OTW firmware updates of 500 and 700+ series controllers (#5321, #5326) * Parallel firmware updates and soft/hard reset during ongoing firmware updates is now prevented (#5220) * Added a readonly `rfRegion` property to the `Controller` class (#5288) * Added support for requesting region-specific firmware updates from the update service (#5296) * Allow configuring the number of kept logfiles (#5294) * Added support for the `Inclusion Controller CC` which allows secondary controllers in the network to include devices on behalf of Z-Wave JS (#4851) * Added support for scanning QR codes that only contain the DSK, as well as pre-filling the DSK before the inclusion process (#5309) ### Bugfixes * Known Wake Up CC version no longer gets overwritten with 1 (#5261) * Surrounding whitespace in S2 or SmartStart QR codes now gets ignored (#5295) * Always use S2 for endpoint communication if the node uses S2 (#5310) * Distinguish between protocol and SDK version on 500 series (#5323) ### Config file changes * Add metadata for Sensative strips (#5223) * Add Ring Retrofit Alarm Kit (#5299) * Correct value size for some Nortek/GoControl device params (#5297) * Correct low temp threshold for Aeotec aërQ (#5286) * Add fingerprint for Fibaro FGWP102 (#5280) * Add metadata to Aeotec aërQ (#5224) * Allow higher minimum dim level for Inovelli LZW31-SN, FW 1.57+ (#5181) * Add Zooz 800 series controllers (#5324) ### Changes under the hood * Removed a workaround for broken caching in the `got` library (#5090)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes our caching band-aid for the firmware update service in favor of the now-fixed built-in caching in
got. In addition, it makes the service URL configurable through the env variableZWAVEJS_FW_SERVICE_URL.fixes: #5213