Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zwave-js to 12.5.0 b1 and add support for LR keys #1141

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

raman325
Copy link
Collaborator

I don't believe any additional functionality is required in the server for long range support but will continue to review the docs

@AlCalzone
Copy link
Member

There are a couple of things that are not available for LR nodes - managing routes, neighbor info, etc.
Not sure if the server should deal with that though.

@raman325
Copy link
Collaborator Author

what happens when attempting to call those methods on a LR node? Will the method throw an error?

@raman325 raman325 merged commit a912713 into master Jan 24, 2024
1 check passed
@raman325 raman325 deleted the zwlr branch January 24, 2024 02:59
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tx @raman325! Looks good to me, I had to disable all the neighbors/priority/return routes calls too, dunno if the driver handles the error, maybe that's something that should be handled only from UI (hide/show some informations based on the protocol)

@raman325
Copy link
Collaborator Author

Not sure I agree. Yes, the UI needs to show and hide functionality based on the node properties but the driver should also (IMO) be smart enough to tell the caller when they are attempting to do something that is unsupported

@AlCalzone
Copy link
Member

I considered raising an error, but since most of the route management methods would only log something and return false when it didn't work, I chose to go that route for now.
It's not like you are going to break something, it just doesn't do anything. Might consider converting to an error in the next major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants