-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config_manager
and utils
commands
#1231
Conversation
I wonder if this should be in a separate |
or maybe |
I vote for |
@marcus-j-davies spoke with Al about this. I added all of the APIs for utils and config manager to be consistent. Sorry for the delayed activity on this but we should be good to merge soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small clarification
config_manager
and utils
commands
@AlCalzone , @raman325
This PR exposes the
lookupDevice
method of theConfigManager
class.I think this should be added, for the following reason.
Often, after scanning a QR Code, front ends might want to display the Device Information, present in the config.
Generally, specifics about the device, not usually found in the QR its self.
I also use this method, during a Smart Start operation, to advise the user the device is unknown, as the return is either a
DeviceConfig
orundefined
Example:
You could argue, why not include this by calling
lookupDevice
during QR Code parsing within the server?But to allow better 1:1 mapping of the API - I didn't, feel free to suggest otherwise.
Now, I am not too familiar with this code base, so let me know if something is not right with my changes.