Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Description for Failed Nodes in Advanced Menu #3190

Closed
The00Dustin opened this issue Jul 26, 2023 · 1 comment · Fixed by #3200
Closed

Better Description for Failed Nodes in Advanced Menu #3190

The00Dustin opened this issue Jul 26, 2023 · 1 comment · Fixed by #3200
Assignees
Labels
enhancement New feature or request

Comments

@The00Dustin
Copy link
Contributor

The00Dustin commented Jul 26, 2023

Is your feature request related to a problem? Please describe.
Under Failed Nodes, the descriptive text currently reads:

Manage nodes that are dead and/or marked as failed with the controller

While this text is certainly accurate when entering the General Actions menu via the Advanced actions button, I believe it should be changed on the Advanced menu for specific devices (which one enters by clicking or tapping the ADVANCED button).

I suggest this because while I now understand that this is where to remove a battery powered device even though it will say sleeping indefinitely (as opposed to dead or failed), there are many search results from people not understanding this, and that confusion may be easy to solve.

Describe the solution you'd like
If the text can be different between the menus, I suggest something like:

Remove this failed node (if it is marked dead or sleeping)

for the individual device menu, with no change to the general actions menu.

Describe alternatives you've considered
My first draft was as follows:

Remove nodes that are not working

However, that was before I realized the same description was used in two different places including one which would never remove a sleeping device.

Additional context
While it is speculation on my part, I believe this is what globe-earther was suggesting in #2651

Note also that https://zwave-js.github.io/zwave-js-ui/#/usage/nodes-management mentions Remove Failed Node when discussing Replace Failed Node, but I couldn't find any prior information on the former. While it is feasible that should be reported and addressed separately, this change could help with that deficit as well.

@The00Dustin The00Dustin added the enhancement New feature or request label Jul 26, 2023
@AlCalzone
Copy link
Member

Removing or replacing failed nodes will work on sleeping nodes too, this is correct. We need to be careful though not to indicate that this is meant to be used as the primary way to remove or replace sleeping nodes.

Remove failed node is only meant to remove devices that cannot be removed by excluding, because the device no longer exists or is truly dead (hardware failure), or the device was factory reset without the controller/Z-Wave JS noticing. This is true for both mains-powered and sleeping devices.

Replace failed node is meant to do the same thing, but by giving the node ID to another new device. This is sometimes "abused" by users who want to reuse the node IDs.

What contributes to the confusion IMO is the "check failed" function. We should probably just remove it from the UI. It simply checks if the device is marked as failed in the controller memory, but this isn't necessary for removal. Z-Wave JS will test if a device is reachable. Only if it isn't, the device can even be removed this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants