Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Allow to change provisioning entries name/loc even when after they have a node binded #3699

Closed
robertsLando opened this issue May 6, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@robertsLando
Copy link
Member

Ref: #3694 (reply in thread)

@robertsLando robertsLando added the enhancement New feature or request label May 6, 2024
@robertsLando robertsLando self-assigned this May 6, 2024
@foxxcomm
Copy link

We are running into this. When we notice a typo or want to change the name or location of a SmartStart entry that is already assigned the edit button is not present. Implementing this would make it easy to update the name or location in Home Assistant by simply editing the SmartStart entry then excluding the device and SmartStart would then re-include the device using the updated name/location.

Thank You

@robertsLando
Copy link
Member Author

@AlCalzone Should this be possible?

@AlCalzone
Copy link
Member

I think it's fine. This info is just for the user anyways.

@foxxcomm
Copy link

@AlCalzone --

Just upgraded to v9.14.0 and tested this. Don't see the edit button active after upgrade on all our SmartStart entries which are already assigned to nodes. Have cleared our browser cache with same results. Should the edit button become active on in-use entries after this upgrade? Let me know if you need debug information and if so where to send it. Thanks!

@robertsLando
Copy link
Member Author

I can see it, could you double check the version please?

2024-06-18_09-57

@foxxcomm
Copy link

zwave-js-ui: 9.14.0
zwave-js: 12.11.0

Re-confirmed browser (latest Chrome) cache is cleared. No change, no edit buttons on active entries. Running zwave-js-ui on Windows in HTTPS mode (self-signed) if that makes any difference.

@robertsLando
Copy link
Member Author

LOL sorry just saw that I pushed the commit after 9.14.0 release. Please wait for 9.14.1 or, if using docker, use master tag isntead

@foxxcomm
Copy link

foxxcomm commented Jun 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants