Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zniffer: Routed acks / errors should be shown in the frame list, not only the details #3775

Closed
AlCalzone opened this issue Jun 17, 2024 · 2 comments · Fixed by #3893
Closed

Comments

@AlCalzone
Copy link
Member

These are frames with routedError: true:
grafik

We should show that those are routed errors and color them red in this view.

Likewise those are frames with routedAck: true:
grafik

We should highlight them like ACKs and show in the payload that they are routed acks.

@robertsLando
Copy link
Member

We should show that those are routed errors and color them red in this view.

row color you mean?

We should highlight them like ACKs and show in the payload that they are routed acks.

Should I use ZWaveFrameType.AckDirect color so for the row? And in the payload column write somethinf like ROUTED ACK ?

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants