-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dialogs API more consistent #156
Comments
Needed to update main window after settings change. Also see zxcalc#156.
Hi, @dlyongemallo @RazinShaikh check this commit commit
|
Dialog Windows are sometimes hidden behind main window #156
Incidentally, make the warning dialogs modal (see issue zxcalc#156).
The original problem of dialog windows being hidden behind the main window is now solved. I have renamed the issue as per @dlyongemallo 's suggestion. The following still needs to be updated:
|
In Qt, the parent is always the first parameter, so that is probably the way to go. I think in general the parent should be the closest QWidget above it, and so the type should be QWidget. |
In
dialogs.py
, the various dialogs don't always take aparent
parameter consistently. In particular,show_error_msg
doesn't take aparent
at all, and error messages can sometimes show up behind the main window which is rendered inactive, which is a confusing state for the user.Also: in other dialog-showing functions, the
parent
parameter is sometimes typedQWidget
and sometimes typedMainWindow
, and it's sometimes the first parameter and sometimes the last. The API would be nicer if this was made consistent.The text was updated successfully, but these errors were encountered: