Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made previews only load once you first hover over the rewrite rule, cutting down on loading time #339

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Made previews only load once you first hover over the rewrite rule, cutting down on loading time #339

merged 2 commits into from
Jul 23, 2024

Conversation

jvdwetering
Copy link
Collaborator

No description provided.

@jvdwetering jvdwetering marked this pull request as ready for review July 22, 2024 15:32
RazinShaikh
RazinShaikh approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@RazinShaikh RazinShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Shall we merge it?

@jvdwetering jvdwetering merged commit e80a835 into master Jul 23, 2024
2 checks passed
@RazinShaikh RazinShaikh deleted the feature/preview-asynchronous branch July 23, 2024 20:54
@RazinShaikh RazinShaikh mentioned this pull request Jul 23, 2024
Closed
@RazinShaikh
Copy link
Collaborator

This PR broke the previews settings. The tooltip shows the preview even when the "Show rewrite previews" is turned off.

@RazinShaikh
Copy link
Collaborator

We need to use

if display_setting.previews_show

but I think it might need a few more changes because currently the following line overwrites the tooltip_str.

zxlive/zxlive/rewrite_action.py

Line 156 in 40d0ea0

self.tooltip_str = '<img src="data:image/png;base64,{}" width="500">'.format(image) + self.tooltip_str

@jvdwetering
Copy link
Collaborator Author

Fixed in f1fb7b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazinShaikh RazinShaikh RazinShaikh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvdwetering @RazinShaikh