Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support for CODABAR code (#194) #195

Merged
merged 10 commits into from
Apr 19, 2023

Conversation

dodobelieve
Copy link
Contributor

[Feature] Support for CODABAR code (#194)

@github-actions
Copy link

Stale pull request message

@github-actions github-actions bot closed this Oct 21, 2019
@odahcam odahcam reopened this Oct 21, 2019
@github-actions github-actions bot closed this Oct 28, 2019
@odahcam odahcam reopened this Oct 29, 2019
@github-actions github-actions bot closed this Nov 5, 2019
@odahcam odahcam reopened this Nov 6, 2019
@github-actions github-actions bot closed this Nov 13, 2019
@odahcam odahcam reopened this Nov 13, 2019
@github-actions github-actions bot closed this Nov 20, 2019
@odahcam odahcam reopened this Nov 21, 2019
@github-actions github-actions bot closed this Nov 28, 2019
@odahcam odahcam reopened this Nov 29, 2019
@github-actions github-actions bot closed this Dec 6, 2019
@odahcam odahcam reopened this Jan 17, 2020
@github-actions github-actions bot closed this Jan 24, 2020
@odahcam odahcam reopened this Jan 25, 2020
@github-actions github-actions bot closed this Feb 1, 2020
@odahcam
Copy link
Member

odahcam commented Feb 2, 2020

Someday I will rule this bot.

@odahcam odahcam reopened this Feb 2, 2020
Copy link
Member

odahcam commented Oct 22, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/core/oned/MultiFormatOneDReader.ts  1
- src/core/oned/CodaBarReader.ts  7
- src/test/core/oned/CodaBarBlackBox1.spec.ts  1
- src/core/common/BitArray.ts  10
- src/test/core/common/BitArray.spec.ts  6
         

See the complete overview on Codacy

@odahcam odahcam linked an issue Nov 30, 2020 that may be closed by this pull request
@thorin8k
Copy link

thorin8k commented Dec 4, 2020

Nice work!

Is this planned to be in the next release?

Thanks

@odahcam odahcam added this to the v1.0.0 milestone Dec 10, 2020
werthdavid
werthdavid previously approved these changes Apr 19, 2023
@werthdavid
Copy link
Member

@dodobelieve can you resolve those conflicts? I will merge it then

@werthdavid werthdavid merged commit 2fd9727 into zxing-js:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

will you add support for CODABAR code?
4 participants