Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added code39 extended mode decode hint #591

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

dalferth
Copy link
Contributor

The Code39Reader has an extendedMode Option. With my enhancement you can now enable the extendedMode like other features via decode hints.

Example:

const hints = new Map();

hints.set(DecodeHintType.POSSIBLE_FORMATS, [BarcodeFormat.CODE_39]);
hints.set(DecodeHintType.ENABLE_CODE_39_EXTENDED_MODE, true);

const codeReader = new BrowserMultiFormatReader(hints);

Copy link

@ollejernstrom ollejernstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This feature will solve a lot of issues people are having with scanning Code39. IMO this should even be the default since Code39 is a subset of Code39Extended

@werthdavid werthdavid merged commit cf4b897 into zxing-js:master Apr 29, 2024
2 checks passed
@werthdavid
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants