allows the poster attribute of the html video tag to be bindable. #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s resolves the 404 noposter issue when using this library.
KPLK
approved these changes
Jul 1, 2023
Kancha1993
approved these changes
Jul 2, 2023
Kancha1993
approved these changes
Jul 2, 2023
werthdavid
approved these changes
Jul 21, 2023
|
Can you please add some "documentation" before I merge it? Add it https://github.com/zxing-js/ngx-scanner/wiki/Advanced-Usage and provide valid values. Thanks!! |
|
Please Srs, I downloaded the version 16.0.1 and this modification is not there yet. I would like to known in which version it will be released ? Thanks in advance. |
|
Oops I think I forgot to create a release... will do it tmrw |
Please, how can I solve that error? [zxing-js/ngx-scanner error: GET http://localhost:4200/noposter 404 (Not Found)] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the 404 noposter issue when using this library.
Currently without a file called 'noposter' at the root of the server an application using this library will make a 404 http call. this allows users to specify a poster or opt to not using one whatsoever. Either way the 404 is resolved.