-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Norwegian translation #878
Conversation
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
=========================================
Coverage 75.26% 75.26%
Complexity 4125 4125
=========================================
Files 250 250
Lines 13990 13990
Branches 2870 2870
=========================================
Hits 10530 10530
Misses 2647 2647
Partials 813 813 Continue to review full report at Codecov.
|
Isn't the language code "no"? By the way, for historical reasons, the "plus" version of this app already had a Norwegian translation. It'll be open-sourced soon. It'd be great to make them consistent as much as makes sense. For your reference, here are the strings from the other app, which mostly overlap with the ones from this one.
|
Norwegian language codes are a hot mess, due to how there's at least 2 writing standards in regular use for it. I've seen both "no" and "nb" in regular use, so I suppose that "no" would also work (Especially if it already worked for the Pro version). I can also see that the guy who did the Pro translation, did a pretty good job at it. Apart from a one-digit amount of half-awkward lines I'd want to change, the guy did a better job than I did. So I will indeed use the Pro lines as my base for a 2nd attempt at a translation of the Free (Standard?) version. |
It was tough to unify the lines to match those of the Free version's strings.xml, but I hope I succeeded at it.
Seeing if I can change the folder name as well.
It's not really Travis, but the Maven build it runs (and that you can run locally if you want).
|
Fixed the two crashing duplicate entries, it seems.
Ah. Thanks for narrowing down the issue. I've removed two of those duplicate lines, and found two lines that I had forgot to add to the 2nd version of the translation. |
So, unless you're seeing something that I don't, I'd say that the file is hereby finished and is ready for merging. |
I wrote a Norwegian translation, based on how I could see that the other translations of Barcode Scanner had been done.