-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable resume download for hf_hub_download #1249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting to make it False
by default in settings.py
to do not explicitly require it in the chain of settings*.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think going for a very simple solution here is way better. Just making it always resume the download seems like a healthy default.
That way you don't have to overcomplicate with a setting that realistically nobody will need to change.
@pabloogc , thank you for your review and suggestions. I agree that resuming downloads by default is a prudent approach. However, to address scenarios where resuming may not be ideal, such as when the model file in the HuggingFace repository has been updated, I propose adding an optional setting in the LocalSettings class. This would allow users to choose whether to resume downloads from the last breakpoint or start afresh, thereby ensuring flexibility and robustness in handling different situations. |
I still wouldn't expose it as a setting, instead pass a parameter to the setup script |
Well, '--resume'/'--no-resume' are added as arguments for the setup script in the new commit. The default value is true. |
enable auto resume download by default to prevent always restart on downloading large file with poor network connection.