Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llm): drop default_system_prompt #1385

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

lopagela
Copy link
Contributor

@lopagela lopagela commented Dec 8, 2023

As discussed on Discord, the decision has been made to remove the system prompts by default, to better segregate the API and the UI usages.

A concurrent PR (#1353) is enabling the dynamic setting of a system prompt in the UI.

Therefore, if UI users want to use a custom system prompt, they can specify one directly in the UI. If the API users want to use a custom prompt, they can pass it directly into their messages that they are passing to the API.

In the highlight of the two use case above, it becomes clear that default system_prompt does not need to exist.

@lopagela lopagela requested a review from imartinez December 8, 2023 19:18
@aly-shehata
Copy link
Contributor

I reviewed this PR and it looks good. I merged this with #1353 locally to test, and everything was functioning. There were minor merge conflicts to resolve which I can help with if needed.

As discussed on Discord, the decision has been made to remove the system prompts by default, to better segregate the API and the UI usages.

A concurrent PR (zylon-ai#1353) is enabling the dynamic setting of a system prompt in the UI.

Therefore, if UI users want to use a custom system prompt, they can specify one directly in the UI.
If the API users want to use a custom prompt, they can pass it directly into their messages that they are passing to the API.

In the highlight of the two use case above, it becomes clear that default system_prompt does not need to exist.
@imartinez imartinez merged commit a3ed14c into zylon-ai:main Dec 8, 2023
6 checks passed
@lopagela lopagela deleted the drop-system-prompt branch December 8, 2023 22:19
simonbermudez pushed a commit to simonbermudez/saimon that referenced this pull request Feb 24, 2024
As discussed on Discord, the decision has been made to remove the system prompts by default, to better segregate the API and the UI usages.

A concurrent PR (zylon-ai#1353) is enabling the dynamic setting of a system prompt in the UI.

Therefore, if UI users want to use a custom system prompt, they can specify one directly in the UI.
If the API users want to use a custom prompt, they can pass it directly into their messages that they are passing to the API.

In the highlight of the two use case above, it becomes clear that default system_prompt does not need to exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants