feat: made chat area stretch to fill the screen #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopagela
previously approved these changes
Dec 15, 2023
imartinez
previously approved these changes
Dec 16, 2023
Co-authored-by: Iván Martínez <ivanmartit@gmail.com>
|
I have completed running the command "make check" and there were no issues found. |
imartinez
approved these changes
Dec 17, 2023
|
Thanks for the contribution @therohitdas ! |
simonbermudez
pushed a commit
to simonbermudez/saimon
that referenced
this pull request
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, are you guys open to making the chat area stretch and fill the height of the screen?
This PR addresses #1377
I have added some CSS to stretch and fill the height of the screen, thanks to @yvrjsharma 's help.
I have tested it using the dev tool. It is responsive and accommodates the recent addition of a system prompt.
Video:
Responsiveness:
First.Half.mov
After Chat Generation:
Second.Half.mov
This will help privateGPT look similar to chatGPT and help with adoption.