Do not let request-building exceptions break crawling #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmike
reviewed
Dec 13, 2024
kmike
approved these changes
Dec 13, 2024
Gallaecio
merged commit ea3ee4b
into
zytedata:job-posting-product-list
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a context manager to capture and log exceptions, and used it in every spider when building a request object, so that any exception from request building does not prevent the rest of the callback code from running normally.
Built on top of #92 because the mockserver makes testing this change really easy (most of those tests failed upon adding those mailto: links, and work after the changes here).