Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't do anything, if there is no src/main/java directory #11

Closed
zyxist opened this issue Mar 8, 2018 · 2 comments
Closed

Don't do anything, if there is no src/main/java directory #11

zyxist opened this issue Mar 8, 2018 · 2 comments
Labels

Comments

@zyxist
Copy link
Owner

zyxist commented Mar 8, 2018

In a multi-project setup, root project usually does not have /src/main/java directory - the sources are in the subprojects. However, the new module name detector fails, if it does not find module-info.java descriptor.

There is a workaround for that:

javaModule.name = ''

It is a bit ugly. Generally, if there is no directory with the sources, we should skip parsing module-info.java at all.

zyxist added a commit that referenced this issue Mar 8, 2018
@zyxist zyxist closed this as completed Mar 8, 2018
@Vampire
Copy link

Vampire commented Mar 9, 2018

You could also mix module-enabled projects and non-module-enabled projects (auto-modules).
So you should probably not depend on whether the source directory is present, but whether there is a module-info.java?
And also there could be multiple source sets, so you shouldn't only pimp the main source set, but also the other source sets?

@Vampire
Copy link

Vampire commented Mar 9, 2018

Yep, I just hit having a non-module-enabled project and your plugin chickens out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants