Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compilerArgs get overwritten #9

Closed
Vampire opened this issue Mar 8, 2018 · 5 comments
Closed

compilerArgs get overwritten #9

Vampire opened this issue Mar 8, 2018 · 5 comments
Labels

Comments

@Vampire
Copy link

Vampire commented Mar 8, 2018

See gradle#10 for full description

@zyxist zyxist added the bug label Mar 8, 2018
@zyxist
Copy link
Owner

zyxist commented Mar 8, 2018

Thanks - it's indeed a limitation.

Regarding doFirst, I'd be cautious. I changed it to doLast while fixing issue #4, and it turned out that Jigsaw parameters stopped being applied at all to the run task. It needs some extera investigation.

@Vampire
Copy link
Author

Vampire commented Mar 8, 2018

No, of course not doLast, that would be worse, as it is run after the existing actions, which is the compiler execution, amongst possible other actions.
Both, doLast and doFirst actions are executed at execution phase though and during execution phase no configuration should be changed, especially not those configurations that could influence the incremental execution, meaning the inputs and outputs of a task and thus its up-to-date check.
Configuration of a task should only be done during the configuration phase, so probably do it in an afterEvaluate block instead to do it at end of configuration phase when the normal configuration actions are done, but still within the configuration phase.

Actually in which block it is done does not change the bug reported here, the bug here is mainly that setCompilerArgs is used instead of getting them and adding the addtional ones. The doLast think was only a side-note that should probably also get fixed.

@zyxist
Copy link
Owner

zyxist commented Mar 8, 2018

Thanks for the explanation. I'll create a separate issue for updating the task configuration, and here I'll just fix for compilerArgs.

@zyxist
Copy link
Owner

zyxist commented Mar 8, 2018

The fix is available on master branch. For now, overriding JVM args it not possible, because it breaks integration tests and I must take a closer look at it. If you notice any problems, feel free to reopen the issue.

@zyxist zyxist closed this as completed Mar 8, 2018
@Vampire
Copy link
Author

Vampire commented Mar 9, 2018

What do you mean by "overriding JVM args is not possible"?
The compilerArgs are the JVM args, aren't they?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants