Merge pull request bnb-chain#2339 from bnb-chain/fix-with-sidecars

fix missing block asigment WithSidecars
zzzckck · Mar 26, 2024 · eda56e2 · eda56e2
2 parents 79cd522 + dddf20e
commit eda56e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/rawdb/accessors_chain_test.go b/core/rawdb/accessors_chain_test.go
@@ -687,7 +687,7 @@ func BenchmarkWriteAncientBlocks(b *testing.B) {
 		blocks := allBlocks[i : i+length]
 		receipts := batchReceipts[:length]
 		for j := 0; j < length; j++ {
-			blocks[i+j].WithSidecars(batchSidecars[j])
+			blocks[i+j] = blocks[i+j].WithSidecars(batchSidecars[j])
 		}
 		writeSize, err := WriteAncientBlocks(db, blocks, receipts, td)
 		if err != nil {

diff --git a/core/state/pruner/pruner.go b/core/state/pruner/pruner.go
@@ -455,7 +455,7 @@ func (p *BlockPruner) backUpOldDb(name string, cache, handles int, namespace str
 		}
 		// if there has blobs, it needs to back up too.
 		blobs := rawdb.ReadRawBlobSidecars(chainDb, blockHash, blockNumber)
-		block.WithSidecars(blobs)
+		block = block.WithSidecars(blobs)
 		// Write into new ancient_back db.
 		if _, err := rawdb.WriteAncientBlocks(frdbBack, []*types.Block{block}, []types.Receipts{receipts}, td); err != nil {
 			log.Error("failed to write new ancient", "error", err)