New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor shop settings forms to use GraphQL #206

Merged

mikemurray merged 48 commits into trunk from refactor-settings-forms-to-use-gql

Mar 5, 2020

Member

willopez commented Feb 6, 2020 •

edited

Loading

Resolves #202
Impact: major
Type: refactor

Summary

This PR updates shop and address settings to use the GraphQL API. And any related Meteor dependencies will be removed.

A new settings sidebar pattern has been introduced, all existing settings have been refactored to use the new pattern.

NOTE: Test along with this corresponding PR in Reaction: reactioncommerce/reaction#6097

Breaking changes

None

Testing

A user should be able to update basic shop settings
A user should be able to update the shop's address

willopez added 5 commits

February 5, 2020 09:56


          refactor: update settings forms to use GraphQL

3df09ac

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add spacing around settings sections

98ef0ea

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add general and address settings panels

49a946f

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          chore: update reacto-form

b99a343

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: wire up a couple of shop settings fields

900a2f2

Signed-off-by: Will Lopez <will.lopez77@gmail.com>

willopez mentioned this pull request

refactor: add translation strings for settings form reactioncommerce/reaction#6097

Merged

willopez added 10 commits

February 7, 2020 15:58


          refactor: wire up general settings

fd391a2

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          Merge branch 'trunk' of github.com:reactioncommerce/reaction-admin in…

c0f2e8f

…to refactor-settings-forms-to-use-gql


          chore: upgrade MUI and reacto-form

d3311e9

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: fix various bugs in general settings form

19c54e8

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: wire up address form

087c92a

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add consistent spacing

76552f6

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: move GraphQL operations into a separate folder

ee3dd52

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          chore: add missing translations

64f4878

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          Merge branch 'trunk' into refactor-settings-forms-to-use-gql

8ff8521


          Merge branch 'trunk' of github.com:reactioncommerce/reaction-admin in…

690696d

…to refactor-settings-forms-to-use-gql

nnnnat added this to the Admin UI milestone

willopez changed the title ~~Refactor settings forms to use GraphqQL~~ Refactor shop settings forms to use GraphqQL

willopez added 7 commits

February 28, 2020 14:51


          refactor: use currentShopId hook

a0d9cd4

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: expose loading prop in useShopSettings hook

f3a0736

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: expose loading prop for real

73a7ac2

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add settings sidebar and revamp shop and address settings

89782cd

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          fix: lint error

2dcb24a

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          chore: upgrade Catalyst

b95ffca

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: move address form to a dialog

ff87443

Signed-off-by: Will Lopez <will.lopez77@gmail.com>

willopez changed the title ~~Refactor shop settings forms to use GraphqQL~~ Refactor shop settings forms to use GraphQL

willopez added 4 commits

March 2, 2020 14:59


          refactor: use MUI loading component

cf84873

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add allow guest checkout to shop settins panel

2e139ef

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          Merge branch 'trunk' of github.com:reactioncommerce/reaction-admin in…

15bb601

…to refactor-settings-forms-to-use-gql

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: remove settings submenu from main sidebar

fef2fee

Signed-off-by: Will Lopez <will.lopez77@gmail.com>

willopez added 12 commits

March 3, 2020 15:13


          refactor: add min-width to secondary sidebar

14c4836

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: integrate the primary/detail layout into settings view

bbbc708

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add initial view to address settings

873a8f3

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add tax settings block region

b85dc17

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          Merge branch 'trunk' of github.com:reactioncommerce/reaction-admin in…

4a1c795

…to refactor-settings-forms-to-use-gql

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          fix: typos

55dd9b1

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: remove unnecessary MUI styles package

d972dd2

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: use makeStyles from core MUI package

a18b558

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add shipping settings block region

64464d9

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add address validation services block region

54ded41

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add headers to settings views

5d7f101

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          fix: lint error

f06913b

Signed-off-by: Will Lopez <will.lopez77@gmail.com>

mikemurray reviewed

View reviewed changes

Member

mikemurray left a comment

I know you're probably still working on this, but I wanted to get a head start of the review. Just some minor things I saw while looking through the code.

imports/plugins/core/dashboard/client/components/StorefrontUrls.js Outdated Show resolved Hide resolved

imports/plugins/core/dashboard/client/components/StorefrontUrls.js Outdated Show resolved Hide resolved

imports/plugins/core/dashboard/client/components/SettingsDashboard.js Outdated Show resolved Hide resolved

imports/plugins/core/dashboard/client/components/SettingsList.js Outdated Show resolved Hide resolved

willopez added 10 commits

March 5, 2020 09:41


          refactor: set correct priority

b421261

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          fix: typo

7e8fe43

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add system information region

a3b4cd9

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add email settings region

812f392

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add localization settings region

a4d3178

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: add email templates settings region

022e17e

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: remove unnecesary Fragment components

e19ed57

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          chore: fix settings sidebar width

31d56de

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          fix: shop settings form mobile styles

128acad

Signed-off-by: Will Lopez <will.lopez77@gmail.com>


          refactor: remove styled components usage

78d56de

Signed-off-by: Will Lopez <will.lopez77@gmail.com>

willopez marked this pull request as ready for review

March 5, 2020 19:45

mikemurray approved these changes

View reviewed changes

Member

mikemurray left a comment

👍 Approved. Issues found have been logged in this ticket #238

mikemurray merged commit ab05e6a into trunk

mikemurray deleted the refactor-settings-forms-to-use-gql branch

March 5, 2020 22:21

kieckhafer mentioned this pull request

release v3.0.0-beta.6 #248

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet