Handle state sync execution failures properly #1676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Failed state sync events execution is handled properly now. Instead of expecting only failed transaction receipt, we should attest whether there is
StateSyncResult
with theSuccess
field set tofalse
. Those state sync events are also considered as failed state sync events.The reason behind it is that
StateReceiver
invokes a target contract (in this caseNativeERC20
), without having a require, but instead only marking it as failed and emitting appropriateStateSyncResult
:https://github.com/0xPolygon/core-contracts/blob/main/contracts/child/StateReceiver.sol#L165-L170
Changes include
Checklist
Testing
Manual tests
0x0
address from cluster script and run it"State sync execution failed. err=failed to execute state sync id..."