Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestE2E_Migration #1702

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Fix TestE2E_Migration #1702

merged 2 commits into from
Jul 5, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Jul 5, 2023

Description

E2E test TestE2E_Migration was failing because of a bug introduced in #1685. Through given PR we moved parsing of premine flag in genesis command to validatePremineInfos function, but that function was only called if consensus is polybft.

Since given E2E test, tests the migration from an older consensus (in this case dev consensus) to polybft, premine flag was not parsed when starting cluster in dev consensus, so the test's checks failed.

This PR fixes the issue, by first parsing premine flag (without checking which consensus is selected), and then calling validate if polybft consensus is in place.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal requested a review from a team July 5, 2023 08:56
@goran-ethernal goran-ethernal self-assigned this Jul 5, 2023
@goran-ethernal goran-ethernal added the bug fix Functionality that fixes a bug label Jul 5, 2023
@goran-ethernal goran-ethernal marked this pull request as ready for review July 5, 2023 08:56
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goran-ethernal goran-ethernal merged commit 18e5529 into develop Jul 5, 2023
7 checks passed
@goran-ethernal goran-ethernal deleted the Fix_TestE2E_Migration branch July 5, 2023 10:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants