Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TestE2E_Consensus_MintableERC20NativeToken to send dynamic fee txs #1920

Merged

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Sep 19, 2023

Description

This a follow-up of #1917, which updates the TestE2E_Consensus_MintableERC20NativeToken e2e test to send dynamic fee transactions to the Edge. Since it relies on a tx relayer component and does not set MaxFeePerGas and MaxPriorityFeePerGas beforehand, it allows tx relayer to estimate those values. In order to calculate MaxFeePerGas, eth_feeHistory is invoked to query the latest base fee (https://github.com/0xPolygon/polygon-edge/blob/fix/update-e2e-test-to-send-eip-1559-transaction/txrelayer/txrelayer.go#L146-L160). If there are no errors in the execution of the test when querying the fee history, it proves that fix in #1917 is correct.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal changed the title Update TestE2E_Consensus_MintableERC20NativeToken to send dynamic fee tx Update TestE2E_Consensus_MintableERC20NativeToken to send dynamic fee txs Sep 19, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Sep 19, 2023
@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Sep 19, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team September 19, 2023 13:38
@Stefan-Ethernal Stefan-Ethernal merged commit 1b78d47 into develop Sep 20, 2023
6 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the fix/update-e2e-test-to-send-eip-1559-transaction branch September 20, 2023 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants