chore: remove conditional compilation for debug_utils #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Thanks David! LGTM!
I'm not against the change, although I don't think this is the source of the issue on zk_evm side. If we're importing within the brackets that are conditionally compiled with -> tested, change needed indeed.debug_assertions, we should be fine IMO.
It's missing an entry in the CHANGELOG however.
|
Updated, my bad. |
Nashtare
approved these changes
Feb 23, 2024
Nashtare
deleted the
dp-remove-conditional-compilation-for-debug_utils
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this PR for the motivation.