Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove conditional compilation for debug_utils #1540

Merged
merged 2 commits into from
Feb 23, 2024
Merged

chore: remove conditional compilation for debug_utils #1540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c937fcc
chore: remove conditional compilation for debug_utils
dvdplm Feb 23, 2024
3b5336c
chore: update CHANGELOG
dvdplm Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

### Changed
Always compile cross_table_lookups::debug_utils ([#1540](https://github.com/0xPolygonZero/plonky2/pull/1540))

## [0.2.0] - 2024-02-20
* Initial CHANGELOG tracking.
6 changes: 2 additions & 4 deletions starky/src/cross_table_lookup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,12 +1041,10 @@ pub fn verify_cross_table_lookups_circuit<
debug_assert!(ctl_zs_openings.iter_mut().all(|iter| iter.next().is_none()));
}

/// Debugging module, to assert correctness of the different CTLs of a multi-STARK system,
/// Debugging module used to assert correctness of the different CTLs of a multi-STARK system,
/// that can be used during the proof generation process.
///
/// **Note**: this is an expensive check, hence is only available when the `debug_assertions`
/// flag is activated, to not hinder performances with regular `release` build.
#[cfg(debug_assertions)]
/// **Note**: This is an expensive check.
Nashtare marked this conversation as resolved.
Show resolved Hide resolved
pub mod debug_utils {
#[cfg(not(feature = "std"))]
use alloc::{vec, vec::Vec};
Expand Down