Adapt the circuitry to zero-bin #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate: trace_decoder
Nashtare
approved these changes
Apr 24, 2024
Comment on lines
1663
to
1675
| if lhs_is_agg { | ||
| agg_inputs | ||
| .set_proof_with_pis_target(&self.segment_aggregation.lhs.agg_proof, lhs_proof); | ||
| } else { | ||
| Self::set_dummy_proof_with_cyclic_vk_pis( | ||
| &self.segment_aggregation.circuit, | ||
| &mut agg_inputs, | ||
| &self.segment_aggregation.lhs.agg_proof, | ||
| lhs_proof, | ||
| ) | ||
| } | ||
| agg_inputs | ||
| .set_proof_with_pis_target(&self.segment_aggregation.lhs.segment_proof, lhs_proof); |
There was a problem hiding this comment.
Could be encapsulated in a helper method, as we do exactly the same for lhs and rhs
Nashtare
reviewed
Apr 24, 2024
#188) * Unify types * Reduce arguments * Reorder args for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies circuits and
proof_genso that they can be used inzero-bin. It also serializes theMemoryStateusingBigArrayand adds dummy segments to the right when necessary, for the same purpose.Note that the segments are added to the right for now, but a later PR will add them to the left for efficiency.