Unify AggregationChildTarget structs and reduce nb of args in method
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
Nashtare
added a commit
that referenced
this pull request
Apr 24, 2024
* Generate all segments prior to proving * Cleanup * Add comment * Apply comments * Apply suggestions * Apply more suggestions * Add MemoryState serialization with BigArray, and fix proof_gen for zero-bin * Change create_transaction_circuit so that it always takes a lhs and a rhs * Differentiate aggregation circuits and fix create_transaction_aggregation. * Fix empty_txn_list and cleanup * Change generate_all_segments so it generates at least two segments * Update default size and .env * Remove extra file * Improve comments * Apply comments * Unify `AggregationChildTarget` structs and reduce nb of args in method (#188) * Unify types * Reduce arguments * Reorder args for consistency --------- Co-authored-by: Robin Salen <salenrobin@gmail.com> Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LindaGuiga This is what I meant by relying on
AggregationChildTarget<D>instead. The current structs are semantically the same, just the internal fields are named differently.