-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: trace decoder tests #596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: trace_decoder
Anything related to the trace_decoder crate.
label
Sep 5, 2024
0xaatif
force-pushed
the
0xaatif/trace-decoder-tests
branch
from
September 5, 2024 17:12
02e258a
to
f760883
Compare
Nashtare
approved these changes
Sep 5, 2024
muursh
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was very difficult to see which test was failing and why in #583.
I've rewritten the integration tests to be more succint, simpler, test more things, and have a better ux:
assert2
to make multiple assertions at once, with more informative output on assertion failure.libtest_mimic
to create test cases for each input file. Test selection, failure attribution all work as expected.trace_decoder::wire
intotrace_decoder/src
- they are completely unrelated to the tests intrace_decoder/tests
.Here's the new UX for a failing test with multiple conditions tripping:
And for passing tests:
Note the
simulate-execution
test needs--quiet
because of this noise (#597)