Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proof_gen crate #650

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Remove proof_gen crate #650

merged 2 commits into from
Sep 23, 2024

Conversation

Nashtare
Copy link
Collaborator

This was actually simpler / quicker than expected, probably could have been grouped with #649.

Motivation:

  • constants module unused
  • ProverStateBuilder / VerifierStateBuilder are not used
  • redundant calls for the proving methods that could be done directly in the ops module of zero
  • custom Result type that was just wrapping errors into Strings

Also renames prove_transaction_aggregation into prove_batch_aggregation for consistency with the chosen names in zero/ (as we don't prove individual transactions anymore but batches).

@Nashtare Nashtare self-assigned this Sep 23, 2024
@github-actions github-actions bot added crate: proof_gen Anything related to the proof_gen crate. crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: zero_bin Anything related to the zero-bin subcrates. ci labels Sep 23, 2024
@Nashtare Nashtare added this to the System strengthening milestone Sep 23, 2024
Copy link
Contributor

@0xaatif 0xaatif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this!

@Nashtare Nashtare merged commit 0dbbb6c into develop Sep 23, 2024
16 checks passed
@Nashtare Nashtare deleted the remove-proof-gen branch September 23, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: proof_gen Anything related to the proof_gen crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants