Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proof_gen crate #650

Merged
merged 2 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@
- changed-files:
- any-glob-to-any-file: trace_decoder/**

# Add 'crate: proof_gen' label to any changes within 'proof_gen' folder.
'crate: proof_gen':
- changed-files:
- any-glob-to-any-file: proof_gen/**

# Add 'crate: zero_bin' label to any changes within 'zero' folder.
'crate: zero_bin':
- changed-files:
Expand Down
25 changes: 0 additions & 25 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,31 +71,6 @@ jobs:
- name: test
run: cargo test --release --manifest-path trace_decoder/Cargo.toml -- --nocapture

test_proof_gen:
name: Test proof_gen
runs-on: ubuntu-latest
timeout-minutes: 30
if: ${{ ! contains(toJSON(github.event.commits.*.message), '[skip-ci]') }}
steps:
- name: Checkout sources
uses: actions/checkout@v4

- name: Install nightly toolchain
uses: dtolnay/rust-toolchain@nightly

- name: Set up rust cache
uses: Swatinem/rust-cache@v2
with:
cache-on-failure: true

- name: Test in proof_gen subdirectory
run: cargo test --manifest-path proof_gen/Cargo.toml
env:
RUSTFLAGS: -Copt-level=3 -Cdebug-assertions -Coverflow-checks=y -Cdebuginfo=0
RUST_LOG: 1
CARGO_INCREMENTAL: 1
RUST_BACKTRACE: 1

test_evm_arithmetization:
name: Test evm_arithmetization
runs-on: ubuntu-latest
Expand Down
15 changes: 1 addition & 14 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ members = [
"evm_arithmetization",
"mpt_trie",
"proc_macro",
"proof_gen",
"smt_trie",
"trace_decoder",
"zero",
Expand Down Expand Up @@ -104,7 +103,6 @@ winnow = "0.6.13"
# local dependencies
evm_arithmetization = { path = "evm_arithmetization", version = "0.4.0", default-features = false }
mpt_trie = { path = "mpt_trie", version = "0.4.1" }
proof_gen = { path = "proof_gen", version = "0.4.0", default-features = false }
smt_trie = { path = "smt_trie", version = "0.1.1" }
trace_decoder = { path = "trace_decoder", version = "0.6.0", default-features = false }
zk_evm_common = { path = "common", version = "0.1.0" }
Expand Down
8 changes: 1 addition & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ understood by the zkEVM prover.
* [evm_arithmetization](./evm_arithmetization/README.md): Defines all the STARK constraints and recursive circuits to generate succinct proofs of EVM execution.
It uses starky and plonky2 as proving backend: https://github.com/0xPolygonZero/plonky2.

* [proof_gen](./proof_gen/README.md): A convenience library for generating proofs from inputs already in Intermediate Representation (IR) format.

* [zero_bin](./zero_bin/README.md): A composition of [`paladin`](https://github.com/0xPolygonZero/paladin) and [`proof_gen`](./proof_gen/README.md) to generate
* [zero_bin](./zero_bin/README.md): A composition of [`paladin`](https://github.com/0xPolygonZero/paladin) and [`evm_arithmetization`](./evm_arithmetization/README.md) to generate
EVM block proofs.

## Dependency graph
Expand All @@ -44,18 +42,14 @@ flowchart LR
B[mpt_trie]
C[evm_arithmetization]
D[trace_decoder]
E[proof_gen]

B --> C
B ---> D
C ---> D
C --> E
D --> E

F{zero-bin}
C --> F
D --> F
E --> F
end
```

Expand Down
2 changes: 1 addition & 1 deletion evm_arithmetization/src/fixed_recursive_verifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2157,7 +2157,7 @@ where
/// This method outputs a tuple of [`ProofWithPublicInputs<F, C, D>`] and
/// its [`PublicValues`]. Only the proof with public inputs is necessary
/// for a verifier to assert correctness of the computation.
pub fn prove_transaction_aggregation(
pub fn prove_batch_aggregation(
&self,
lhs_is_agg: bool,
lhs_proof: &ProofWithPublicInputs<F, C, D>,
Expand Down
2 changes: 1 addition & 1 deletion evm_arithmetization/tests/global_exit_root.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use evm_arithmetization::testing_utils::{
ADDRESS_SCALABLE_L2_ADDRESS_HASHED, GLOBAL_EXIT_ROOT_ACCOUNT, GLOBAL_EXIT_ROOT_ADDRESS_HASHED,
};
use evm_arithmetization::verifier::testing::verify_all_proofs;
use evm_arithmetization::{AllStark, Node, StarkConfig};
use evm_arithmetization::{AllStark, Node, StarkConfig, EMPTY_CONSOLIDATED_BLOCKHASH};
use keccak_hash::keccak;
use mpt_trie::partial_trie::{HashedPartialTrie, PartialTrie};
use plonky2::field::goldilocks_field::GoldilocksField;
Expand Down
2 changes: 1 addition & 1 deletion evm_arithmetization/tests/two_to_one_block.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ fn get_test_block_proof(
let dummy0_proof =
all_circuits.prove_segment_aggregation(false, &dummy1_proof[0], false, &dummy1_proof[1])?;

let (agg_proof, pv) = all_circuits.prove_transaction_aggregation(
let (agg_proof, pv) = all_circuits.prove_batch_aggregation(
false,
&inputs0_proof.proof_with_pis,
inputs0_proof.public_values,
Expand Down
36 changes: 0 additions & 36 deletions proof_gen/Cargo.toml

This file was deleted.

43 changes: 0 additions & 43 deletions proof_gen/README.md

This file was deleted.

27 changes: 0 additions & 27 deletions proof_gen/src/constants.rs

This file was deleted.

Loading
Loading