Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: startGovernedUpgradable subsumes economicCommitteeCreatorFacet etc. #5

Closed
dckc opened this issue Aug 3, 2023 · 4 comments
Closed

Comments

@dckc
Copy link
Collaborator

dckc commented Aug 3, 2023

minor nit: economicCommitteeCreatorFacet isn't directly used by this proposal, so it's not essential here:

"contractGovernor": "priceFeed",
"econCharterKit": "priceFeed",
"economicCommitteeCreatorFacet": "priceFeed",
"highPrioritySendersManager": "priceFeed",
"namesByAddressAdmin": "priceFeed",
"priceAuthority": "priceFeed",
"priceAuthorityAdmin": "priceFeed",
"startGovernedUpgradable": "priceFeed",

Likewise contractGovernor, I think.

But they're used indirectly via startGovernedUpgradable, so I suppose it doesn't hurt to reiterate them.

0xpatrickdev added a commit that referenced this issue Aug 8, 2023
…or powers

- remove powers/authority not essential to the script
- closes #5
0xpatrickdev added a commit that referenced this issue Aug 8, 2023
- use STATOM1 instead STATOM for testing
- limit powers in oracle proposal (economicCommitteeCreatorFacet, contractGovernor) see #5
- use testnet oracle address (+ my own) see #3
- bundles: use node v16.18.1, go 1.20.2, agoric-sdk master#9d4eaad see #9
@dckc
Copy link
Collaborator Author

dckc commented Aug 9, 2023

Agoric/agoric-sdk@b414246 looks like a good fix, but it seems newer than the bundles here. Care to regenerate the bundles? or at least the IDs in the README?

@dckc
Copy link
Collaborator Author

dckc commented Aug 9, 2023

@0xpatrickdev
Copy link
Owner

In this commit in this branch, I removed the economicCommitteeCreatorFacet and contractGovernor powers. The build files in #11 use this fork/branch, so from our local testing it would seem things work as expected without these powers.

We can maybe mark this closed since #11 is merged in. Also can leave it open until the changes land in agoric-sdk via pr(s).

@dckc
Copy link
Collaborator Author

dckc commented Aug 21, 2023

I made a separate PR for agoric-sdk: Agoric/agoric-sdk#8226

I think this issue is best scoped to this repo, so it's fixed in #11.

@dckc dckc closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants