-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: startGovernedUpgradable subsumes economicCommitteeCreatorFacet etc. #5
Comments
…or powers - remove powers/authority not essential to the script - closes #5
Agoric/agoric-sdk@b414246 looks like a good fix, but it seems newer than the bundles here. Care to regenerate the bundles? or at least the IDs in the README? |
ah. now I see the updated bundles: https://github.com/0xpatrickdev/agoric-vault-collateral-proposal/blob/feat/statom1/README.md fef112e |
In this commit in this branch, I removed the We can maybe mark this closed since #11 is merged in. Also can leave it open until the changes land in |
I made a separate PR for agoric-sdk: Agoric/agoric-sdk#8226 I think this issue is best scoped to this repo, so it's fixed in #11. |
minor nit:
economicCommitteeCreatorFacet
isn't directly used by this proposal, so it's not essential here:agoric-vault-collateral-proposal/add-stATOM-oracles-permit.json
Lines 8 to 15 in 1aa1b70
Likewise
contractGovernor
, I think.But they're used indirectly via
startGovernedUpgradable
, so I suppose it doesn't hurt to reiterate them.The text was updated successfully, but these errors were encountered: