fix(inter): remove excess authority in price-feed-proposal.js #8226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Aug 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@dckc - This PR appears to be stuck. It's had a merge label for > 24 hours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8176, 0xpatrickdev/agoric-vault-collateral-proposal#5
Description
Prune permit for
economicCommitteeCreatorFacet,contractGovernorinprice-feed-proposal.js, since they are subsumed bystartGovernedUpgradable.Security Considerations
proposal is slightly less confusing to read
Scaling Considerations
n/a
Documentation Considerations
Do we document contributors anywhere in particular?
ack: @0xpatrickdev
Testing Considerations
existing tests should suffice
Upgrade Considerations
This should slightly simplify future proposals to add collaterals.