[TECH] Récupérer les correlations IDs dans le logger.js (PIX-12823) #9425
+118
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
dlahaye
changed the title
dlahaye
force-pushed
the
pix-12823-add-correlation-id-to-logs-v2
branch
from
703409c
to
f913844
Compare
dlahaye
force-pushed
the
pix-12823-add-correlation-id-to-logs-v2
branch
from
f913844
to
9ec29d1
Compare
dlahaye
commented
Jul 5, 2024
| */ | ||
| const logErrorWithCorrelationIds = _logWithCorrelationIds(internalLogger.error); | ||
|
|
||
| /** @param {object} data |
There was a problem hiding this comment.
Suggested change
| /** @param {object} data | |
| /** @param {object|string} data |
Et idem pour la jsDoc du logError
There was a problem hiding this comment.
au passage est-ce qu'on en profiterait pas pour proposer une jsDoc aussi exhaustive pour le logInfo que ce qui a été fait pour le logError ?
dlahaye
commented
Jul 5, 2024
Comment on lines
97
to
98
| error: _logWithCorrelationIds(internalLogger.error), | ||
| info: _logWithCorrelationIds(internalLogger.info), |
There was a problem hiding this comment.
suite aux remontées d'erreur de la CI:
/home/circleci/pix/api/node_modules/pino/lib/tools.js:59
if (typeof this[msgPrefixSym] === 'string' && msg !== undefined && msg !== null) {
Je pense qu'il faudrait plutôt faire comme ça
Suggested change
| error: _logWithCorrelationIds(internalLogger.error), | |
| info: _logWithCorrelationIds(internalLogger.info), | |
| error: _logWithCorrelationIds(internalLogger.error.bind(internalLogger)), | |
| info: _logWithCorrelationIds(internalLogger.info.bind(internalLogger)), |
Ou un truc du genre 😅
aurelie-crouillebois
force-pushed
the
pix-12823-add-correlation-id-to-logs-v2
branch
from
c201409
to
457be8c
Compare
aurelie-crouillebois
force-pushed
the
pix-12823-add-correlation-id-to-logs-v2
branch
from
457be8c
to
2f4be3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Ajout d'infos dans les logs. Les correlationIDs (
request-id&user-id) ne sont pas loggués partout pour l'instant.Le but est de pouvoir prévenir automatiquement chaque équipe en cas d'erreur, en fonction d'un label
@teamqu'il faudra ajouter sur chaque route.🤖 Proposition
Dans le fichier
logger.js, utiliserloggerInfoWithCorrelationIdlors de l'appel delogger.info, etloggerErrorWithCorrelationIdlors de l'appel delogger.error.Le
logger.jsexpose alors sesloggerInfoWithCorrelationIdetloggerErrorWithCorrelationIdafin de permettre àmonitoring-toolsde les utiliser sans nécessiter de grosses refacto🌈 Remarques
Pour l'instant
logger.warn&logger.trace&logger.fatal&logger.debugne sont pas gérées.💯 Pour tester