Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Migrer la route GET /api/password-reset-demands/{temporaryKey} vers src/identity-access-management (PIX-12749). #9447

Conversation

mariannebost
Copy link
Contributor

@mariannebost mariannebost commented Jul 3, 2024

🦄 Problème

La route GET/api/password-reset-demands/{temporaryKey} est dans le dossier lib.

🤖 Proposition

Migrer la route GET/api/password-reset-demands/{temporaryKey} dans le dossier src/identity-access-management/password

🌈 Remarques

ras

💯 Pour tester

  • en local : activer la variable DEBUG="pix:mailer:email"
    OU en RA : se créer un compte utilisateur avec un mail valide.
  • Aller sur la page de connexion de Pix App
  • Faire la demande de reset de mot de passe "Mot de passe oublié" (un mail est envoyé pour reset le mot de passe)
  • Ouvrir la console du navigateur
  • Aller l'url de redirection figurant dans le corps du mail de format /changer-mot-de-passe/{TemporaryKey}/?lang=fr
  • Constater en console un appel à la route GET /api/password-reset-demands/{TemporaryKey} avec un statut 200
  • constater que la réponse de cette route est de type
{
	"data": {
		"type": "users",
		"id": "XXXXX",
		"attributes": {
			"first-name": "XXXXX",
			"last-name": "XXXXX",
			"email": "XXXXX@XXXXX",
			"username": "XXXXX",
			"cgu": true,
			"last-terms-of-service-validated-at": "XXXXX",
			"must-validate-terms-of-service": false,
			"pix-orga-terms-of-service-accepted": false,
			"pix-certif-terms-of-service-accepted": true,
			"lang": "fr",
			"locale": null,
			"is-anonymous": false,
			"has-seen-assessment-instructions": false,
			"has-seen-level-seven-info": false,
			"has-seen-new-dashboard-info": false,
			"has-seen-focused-challenge-tooltip": false,
			"has-seen-other-challenges-tooltip": false,
			"last-data-protection-policy-seen-at": null,
			"should-see-data-protection-policy-information-banner": true
		},
		"relationships": {
			"profile": {
				"links": {
					"related": "/api/users/XXXXX/profile"
				}
			},
			"campaign-participations": {
				"links": {
					"related": "/api/users/XXXXX/campaign-participations"
				}
			},
			"is-certifiable": {
				"links": {
					"related": "/api/users/XXXXX/is-certifiable"
				}
			},
			"trainings": {
				"links": {
					"related": "/api/users/XXXXX/trainings"
				}
			}
		}
	}
}
  • constater l'affichage du formulaire de saisie du nouveau mot de passe avec le nom d'utilisateur attendu.
  • terminer le processus de réinitialisation de mot de passe et constater qu'il est correct.

@mariannebost mariannebost self-assigned this Jul 3, 2024
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@mariannebost mariannebost force-pushed the pix-12749-migrate-password-reset-demands-temporary-to-src branch from b5f804b to 22d81d7 Compare July 3, 2024 15:01
@mariannebost mariannebost force-pushed the pix-12749-migrate-password-reset-demands-temporary-to-src branch 3 times, most recently from abbee9d to b7a3acd Compare July 5, 2024 09:43
@EmmanuelleBonnemay EmmanuelleBonnemay force-pushed the pix-12749-migrate-password-reset-demands-temporary-to-src branch 2 times, most recently from 9c66161 to a2f2c18 Compare July 5, 2024 15:07
@mariannebost mariannebost marked this pull request as ready for review July 8, 2024 07:52
@mariannebost mariannebost requested a review from a team as a code owner July 8, 2024 07:52
@mariannebost mariannebost force-pushed the pix-12749-migrate-password-reset-demands-temporary-to-src branch 3 times, most recently from 63c0ddf to 31e96ee Compare July 8, 2024 10:26
@mariannebost
Copy link
Contributor Author

Func review ok sur Chrome en RA ✅
Capture d’écran 2024-07-08 à 15 37 29

Copy link
Contributor

@bpetetot bpetetot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Relu et testé sur Chrome

Copy link
Contributor

@yaf yaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bpetetot bpetetot added 🚀 Ready to Merge Func Review OK PO validated functionally the PR and removed 👀 Func Review Needed labels Jul 15, 2024
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-12749-migrate-password-reset-demands-temporary-to-src branch 2 times, most recently from 0645b2d to 69a644c Compare July 15, 2024 08:09
mariannebost and others added 6 commits July 15, 2024 08:14
Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
Co-authored-by: Emmanuelle Bonnemay <emmanuelle.bonnemay@pix.fr>
Co-authored-by: LEGO Technix <109212476+lego-technix@users.noreply.github.com>
Co-authored-by: Emmanuelle Bonnemay <emmanuelle.bonnemay@pix.fr>
Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Emmanuelle Bonnemay <emmanuelle.bonnemay@pix.fr>
Co-authored-by: Emmanuelle Bonnemay <emmanuelle.bonnemay@pix.fr>
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-12749-migrate-password-reset-demands-temporary-to-src branch from 69a644c to 0170ada Compare July 15, 2024 08:14
@pix-service-auto-merge pix-service-auto-merge merged commit 47b8062 into dev Jul 15, 2024
5 of 7 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-12749-migrate-password-reset-demands-temporary-to-src branch July 15, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants