get_term_tree(): fix infinite loop for non-existent parent #2687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
When calling
get_term_tree()
and a term has a parent ID that doesn't exist (possibly due to reasons such as a bad import), we should check for that to prevent an infinite loop from occurring.Reproduction steps:
Alternate Designs
N/A
Possible Drawbacks
None that comes to mind.
Verification Process
Reproduce the reproduction steps with the PR applied and ensure no critical errors occur.
Checklist:
Changelog Entry
Fixed - get_term_tree() will no longer infinite loop when parent ID is non-existent
Credits
Props @rebeccahum