Performance: Use get_term() instead of term_exists() for get_term_tree() #2883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This is a follow-up to the change in #2687. It'd be better to use
get_term()
to utilize the Object cache, sinceterm_exists()
does a DB call and thus, if there are several terms with the same parent, that generates a lot of queries.Alternate Designs
N/A.
Possible Drawbacks
N/A.
Verification Process
Did the same steps described in #2687 but ensure that object caching is utilized.
Checklist:
Changelog Entry
Changed: Improved performance in get_term_tree()
Credits
Props @rebeccahum