Syncs: status and error handling #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The code in this PR handles fatal errors during sync processes, so it does not get stuck but rather gets properly cleaned and logged. It also adds a new WP-CLI command:
get-last-syncwith the information of the latest sync performed, no matter the method (dashboard or cli.)Closes #2737
Verification Process
In addition to the regular checks, running
php -d max_execution_time=1 "$(which wp)" elasticpress index --per-page=2makes the sync timeout, generating the main error the PR tries to fix.Changelog Entry
Added: New
get-last-syncWP-CLI command.Changed: Log errors and remove indexing status on failed syncs.
Credits
Props @felipeelia