Log error messages in the dashboard #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakePT
requested changes
Aug 9, 2022
Co-authored-by: JakePT <JakePT@users.noreply.github.com>
JakePT
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
After #2748, fatal error messages are correctly displayed in WP-CLI. This PR makes an adjustment so it is also displayed in the Sync Dashboard.
Closes #2922
How to test the Change
In an installation with a big number of posts, set
max_execution_time = 1in an ini file and run the sync via the dashboard.Changelog Entry
Credits
Props @felipeelia @orasik