-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process Existing Images with Computer Vision #135
Process Existing Images with Computer Vision #135
Conversation
…rescan for tags and/or captions
@jeffpaul I've implemented the buttons and associated endpoints to allow scanning in the media modal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rescan button, rescan checkbox and generate checkbox work as expected, only some minor bugs remain.
@dinhtungdu thanks for the review! I've addressed the issues you pointed out and just had one question for you. |
@dinhtungdu this is ready for review. Thanks! |
Adds logic to display correct CTA on the attachement edit screen.
@dinhtungdu I've added a couple of changes. This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @ryanwelcher, let get this merged 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@ryanwelcher noting there are a couple merge conflicts to resolve before we get this merged in, you able to handle those conflicts? |
@dinhtungdu I resolved the merge conflicts and pushed. Can you review so I can merge, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I found a case when the API credentials are wrong or expired, the spinner will run forever without any feedback to users. In the media detail page, check But due to our milestone, I think we can ship this PR and address the mentioned issue separately. |
Description of the Change
This PR introduces two features:
Benefits
These features will allow users to process existing images via the admin.
Checklist:
Applicable Issues
#75