Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 1.5.0 #186

Closed
19 tasks done
jeffpaul opened this issue Feb 26, 2020 · 3 comments · Fixed by #187
Closed
19 tasks done

Release version 1.5.0 #186

jeffpaul opened this issue Feb 26, 2020 · 3 comments · Fixed by #187
Assignees
Milestone

Comments

@jeffpaul
Copy link
Member

jeffpaul commented Feb 26, 2020

This issue is for tracking changes for the 1.5.0 release. Target release date: Thursday, February 27th.

Pre-release steps

Release steps

  • Branch: Starting from develop, cut a release branch named release/1.5.0 for your changes.
  • Version bump: Bump the version number in classifai.php, config.php, package-lock.json, package.json, and classifai.pot if it does not already reflect the version being released.
  • Changelog: Add/update the changelog in CHANGELOG.md.
  • Translations: Update the .pot file by running npm run makepot.
  • Props: update CREDITS.md file with any new contributors, confirm maintainers are accurate
  • New files: Check to be sure any new files/paths that are unnecessary in the production version are included in .github/action-release/rsync-filter.txt.
  • Readme updates: Make any other readme changes as necessary in CHANGELOG.md and README.md.
  • Merge: Make a non-fast-forward merge from your release branch to develop (or merge the pull request), then do the same for develop into master (git checkout master && git merge --no-ff develop). master contains the stable development version.
  • Push: Push your master branch to GitHub (e.g. git push origin master).
  • Wait for build: Head to the Actions tab in the repo and wait for it to finish if it hasn't already. If it doesn't succeed, figure out why and start over.
  • Check the build: Check out the stable branch and test for functionality locally.
  • Release: Create a new release, naming the tag and the release with the new version number, and targeting the stable branch. Paste the changelog from CHANGELOG.md into the body of the release and include a link to the closed issues on the 1.5.0 milestone. The release should now appear under releases and in the WordPress admin as an update as well.
  • Close milestone: Edit the 1.5.0 milestone with release date (in the Due date (optional) field) and link to GitHub release (in the Description field), then close the milestone.
  • Punt incomplete items: If any open issues or PRs which were milestoned for 1.5.0 do not make it into the release, update their milestone to 1.5.1, 1.6.0, 2.0.0 or Future Release.
@jeffpaul jeffpaul added this to the 1.5.0 milestone Feb 26, 2020
@jeffpaul jeffpaul mentioned this issue Feb 26, 2020
6 tasks
@jeffpaul jeffpaul reopened this Feb 27, 2020
@jeffpaul
Copy link
Member Author

Noting here that the release process errored out here: https://github.com/10up/classifai/runs/472927828?check_suite_focus=true. Which relates to this step in the release process:

echo "ℹ︎ Configuring git"
. My suspicion is that the https://github.com/10upbot account is no longer in the 10up org or with access to ClassifAI and causing the failure, but I'll review next week when necessary folks are around to chat with. Apologies for the delay on the release.

@helen
Copy link
Contributor

helen commented Mar 3, 2020

I think this may need a git fetch origin before it does the worktree bit, can try it from a branch off master and see if it runs correctly upon merge.

@ryanwelcher
Copy link
Contributor

1.5.0 is live https://github.com/10up/classifai/releases/tag/1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants