-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Pages are not being scanned by Language Processing #164
Conversation
Add new filter to support custom post type with custom rest base
Co-Authored-By: Ryan Welcher <ryan.welcher@10up.com>
@dinhtungdu great work on this! I'm thinking we should have some unit tests to cover pages - any objections? |
@dinhtungdu I'm not sure what we're testing here. I think we want to be sure that when a page is saved, it is being scanned. |
@ryanwelcher I added test for The issue only happens for block editor only, so I think WPAcceptance tests will be better fit and more straight forward. We can wait for #179 to be merged then continue work on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dinhtungdu that works for me - merge away!
Description of the Change
is_rest_route
).classifai_rest_bases
) to support custom post type with custom rest base.is_gutenberg_page
).Benefits
Pages now are scanned and tagged by Language Processing.
Verification Process
Checklist:
Applicable Issues
Closes #161