Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Pages are not being scanned by Language Processing #164

Merged
merged 11 commits into from
Feb 26, 2020
Merged

Fix: Pages are not being scanned by Language Processing #164

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c285a72
remove unused enqueue and depreated `is_gutenberg_page` function calls.
dinhtungdu Jan 16, 2020
86663e5
add page to rest route check.
dinhtungdu Jan 16, 2020
81b55e3
Merge branch 'develop' into fix/pages-not-scanned-161
dinhtungdu Jan 17, 2020
15db818
fix: comment typo
dinhtungdu Feb 18, 2020
27be80e
Merge branch 'develop' into fix/pages-not-scanned-161
dinhtungdu Feb 18, 2020
4d5991a
test: add test for SavePostHandler::is_rest_route
dinhtungdu Feb 24, 2020
56f1c78
test: update check for non posts route
dinhtungdu Feb 24, 2020
b3614bd
Merge branch 'develop' into fix/pages-not-scanned-161
Feb 25, 2020
865c341
Merge branch 'develop' into fix/pages-not-scanned-161
dinhtungdu Feb 26, 2020
bdd682f
Merge branch 'develop' into fix/pages-not-scanned-161
Feb 26, 2020
10cf2ce
Merge branch 'develop' into fix/pages-not-scanned-161
jeffpaul Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions includes/Classifai/Admin/SavePostHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,20 @@ public function show_error_if() {
* @return bool
*/
public function is_rest_route() {
if ( isset( $_SERVER['REQUEST_URI'] ) && false !== strpos( $_SERVER['REQUEST_URI'], 'wp-json/wp/v2/post' ) ) {
return true;

if ( ! isset( $_SERVER['REQUEST_URI'] ) ) {
return false;
}

// Support custome post types with custom rest base.
dinhtungdu marked this conversation as resolved.
Show resolved Hide resolved
$rest_bases = apply_filters( 'classifai_rest_bases', array( 'posts', 'pages' ) );

foreach ( $rest_bases as $rest_base ) {
if ( false !== strpos( $_SERVER['REQUEST_URI'], 'wp-json/wp/v2/' . $rest_base ) ) {
return true;
}
}

return false;
}

Expand Down
24 changes: 0 additions & 24 deletions includes/Classifai/Providers/Watson/NLU.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,30 +173,6 @@ public function enqueue_editor_assets() {
CLASSIFAI_PLUGIN_VERSION,
true
);
if ( function_exists( 'is_gutenberg_page' ) && is_gutenberg_page() ) {
wp_enqueue_script(
'classifai-gutenberg-support',
CLASSIFAI_PLUGIN_URL . 'assets/js/classifai-gutenberg-support.js',
[ 'editor' ],
CLASSIFAI_PLUGIN_VERSION,
true
);
}
}

/**
* Adds ClassifAI Gutenberg Support if on the Gutenberg editor page
*/
public function init_admin_scripts() {
if ( function_exists( 'is_gutenberg_page' ) && is_gutenberg_page() ) {
wp_enqueue_script(
'classifai-gutenberg-support',
CLASSIFAI_PLUGIN_URL . 'assets/js/classifai-gutenberg-support.js',
[ 'editor' ],
CLASSIFAI_PLUGIN_VERSION,
true
);
}
}

/**
Expand Down