Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: WP-CLI command to bulk classify images #177

Merged
merged 18 commits into from
Feb 26, 2020

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Jan 23, 2020

Description of the Change

Add a new WP CLI command image to (bulk) classify uploaded images. By default, this command classifies all images that don't have alt.

Arguments:

  • attachment_ids: Comma delimeted Attachment IDs to classify

Flags:

  • --limit=number: Limit classification to N attachments. Default false.
  • --force: Force classification to first N attachments. Default false.

Alternate Designs

n/a.

Benefits

Able to classify images in bulk by using CLI.

Possible Drawbacks

n/a

Verification Process

Try possible options/flags above.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #95

@jeffpaul jeffpaul added the type:enhancement New feature or request. label Jan 24, 2020
@dinhtungdu dinhtungdu marked this pull request as ready for review January 27, 2020 00:08
@jeffpaul jeffpaul added this to the 1.5.0 milestone Jan 27, 2020
@jeffpaul jeffpaul mentioned this pull request Feb 26, 2020
19 tasks
Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinhtungdu I think this is a nice approach. Well done!

@ryanwelcher ryanwelcher merged commit 6c37bf0 into develop Feb 26, 2020
@jeffpaul jeffpaul deleted the feature/image-processing-wp-cli branch March 5, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WP-CLI command to bulk classify images
5 participants