Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to obsolete process_image method in favor of new functions #195

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Remove references to obsolete process_image method in favor of new functions #195

merged 3 commits into from
Mar 6, 2020

Conversation

johnwatkins0
Copy link
Member

Description of the Change

The process_image method was removed in 1.5, but not all references to the function were removed. One was in a hook callback, and one was in the CLI command. Both have been updated to use the new functions.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@jeffpaul jeffpaul added this to the 1.5.1 milestone Mar 6, 2020
@jeffpaul jeffpaul added the type:bug Something isn't working. label Mar 6, 2020
@jeffpaul jeffpaul mentioned this pull request Mar 6, 2020
Closed
17 tasks
ryanwelcher
ryanwelcher approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ryanwelcher ryanwelcher mentioned this pull request Mar 6, 2020
Merged
6 tasks
@helen helen merged commit 37f8a9d into develop Mar 6, 2020
@helen helen deleted the fix/process-image-callback branch March 6, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanwelcher ryanwelcher ryanwelcher approved these changes

@helen helen Awaiting requested review from helen

Assignees

@johnwatkins0 johnwatkins0

Labels
type:bug Something isn't working.
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@johnwatkins0 @ryanwelcher @helen @jeffpaul