Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds test for ensuring that attachment meta data is set. #198

Merged
merged 6 commits into from
Mar 6, 2020
Merged

Adds test for ensuring that attachment meta data is set. #198

merged 6 commits into from
Mar 6, 2020

Conversation

ryanwelcher
Copy link
Contributor

@ryanwelcher ryanwelcher commented Mar 6, 2020 •
edited
Loading

Description of the Change

Adds a Unit Test to ensure that meta is being correctly added to attachments.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@jeffpaul jeffpaul mentioned this pull request Mar 6, 2020
Closed
17 tasks
@jeffpaul jeffpaul added this to the 1.5.1 milestone Mar 6, 2020
@jeffpaul jeffpaul requested a review from helen March 6, 2020 19:46
@ryanwelcher
Copy link
Contributor Author

The test that is failing will be resolved once #195 is included in this branch.

@helen helen merged commit 26f18a3 into develop Mar 6, 2020
@jeffpaul jeffpaul deleted the feature/add-visual-tests-for-uploads branch October 21, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helen helen helen approved these changes

Assignees

@ryanwelcher ryanwelcher

Labels
None yet
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanwelcher @helen @jeffpaul