Ensure that updating the "Recommended Content Block" settings works correctly. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdharmesh
requested review from
dkotter,
jeffpaul and
a team
as code owners
iamdharmesh
requested review from
faisal-alvi
and removed request for
a team
faisal-alvi
approved these changes
Nov 27, 2023
dkotter
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The pull request (PR) fixes the issue that occurs when updating the "Recommended Content Block" settings. The root cause of the issue is in #609, where we moved the TaxonomyControls component to the src directory and made changes to it as per the requirements for previewing the content classification. Consequently, it started failing due to some unavailable data resulting from the new modifications. This PR adds the old component back to make it work as intended.
Closes #624
Note
We don't have E2E tests for the "Recommended Content Block" because the "Azure AI Personalizer" service will be retired in 2026, and we are unable to create new Personalizer resources. Please let me know if you think we should add E2E tests for this.
How to test the Change
Changelog Entry
Credits
Props @iamdharmesh
Checklist: